From 80cb94f767a9da585ca2f3d2b31434378f4d5f4b Mon Sep 17 00:00:00 2001 From: Nikolai Rodionov Date: Wed, 29 Mar 2023 17:29:47 +0200 Subject: [PATCH] content: Fix the typo --- .../argocd-dynamic-environment-per-branch-part-1/index.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/content/posts/argocd-dynamic-environment-per-branch-part-1/index.md b/content/posts/argocd-dynamic-environment-per-branch-part-1/index.md index 17067a3..bdb632f 100644 --- a/content/posts/argocd-dynamic-environment-per-branch-part-1/index.md +++ b/content/posts/argocd-dynamic-environment-per-branch-part-1/index.md @@ -217,7 +217,7 @@ spec: app: badhouseplants branch: main chart_version: 0.3.6 - # Image that is lates now, we'll get there later + # Image that is latest now, we'll get there later value: | hugo: image: @@ -376,7 +376,7 @@ And now let's create a job like that: - argocd app wait -l app=badhouseplants -l branch=$DRONE_BRANCH ``` -And the last step would be to remove an application when branch is removed. It could be easy with `Gitlab` because there you can use `environments` and `triggers` for removing branch *(as I remember)* But with `drone` it seems to be harder. Because `drone` won't be triggered by a removed branch. +And the last step would be to remove an application when branch is merged. It could be easy with `Gitlab` because there you can use `environments` and `triggers` for removing branch *(as I remember)* But with `drone` it seems to be harder. Because `drone` won't be triggered by a removed branch. Maybe a pull request trigger could be used for that, but I've found another way, which may not be the best, obviously. I've enabled only `fast-forward` merge to the `main` that that means that after merging a Pull Request the commit will have the same `SHA`. So when merging to the main branch, I can use the commit hash to remove a generator. It also means that if I have one commit deployed to several environments, I will remove more that I want. But I don't think that it will be a problem in my case. If you're not a lonely developer, but a team, you may need to choose something else.